Skip to content

i18n(ja): astro-courses #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 8, 2025
Merged

i18n(ja): astro-courses #12416

merged 13 commits into from
Oct 8, 2025

Conversation

Kenzo-Wada
Copy link
Contributor

Description (required)

japanese translation for /astro-course/

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 568338b
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68e66d64f7d0760008550c5d
😎 Deploy Preview https://deploy-preview-12416--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 25, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 25, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/astro-courses.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

jp-knj
jp-knj requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@jp-knj jp-knj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @Kenzo-Wada!
I only skimmed it for now, but the overall direction looks solid. I’ll take a closer look later and leave more detailed comments. Really appreciate you opening this and getting the ball rolling!

src/content/docs/ja/astro-courses.mdx Outdated
title: Astroコース
sidebar:
label: コース
description: Astroを学べる、宇宙級のコースとチュートリアル。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「宇宙級」はダジャレ感が強く、Docsの常体テキストとしては浮きませんか。

もし“宇宙”ニュアンスを少し残すなら、見出しは素直にして、サブコピーで軽く触れるのが良いのかな
「Astroを学べるコースとチュートリアル - Astroの世界を基礎から実践まで」

...良い案は浮かびませんでした 🙏🏿

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a5559ca

郷には入れば郷にしたがう気持ちで、そのまま採用させてください！:pray: （将来リライトも可能だと思うので）

@Kenzo-Wada Kenzo-Wada requested a review from jp-knj September 25, 2025 12:32
jp-knj
jp-knj reviewed Oct 4, 2025
View reviewed changes
Copy link
Member

@jp-knj jp-knj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お手数かけしました。細かなコメントをいくつか残しました。ご対応いただければ、嬉しいです。@Kenzo-Wada

@Kenzo-Wada
Copy link
Contributor Author

@jp-knj レビューありがとうございますー！コメントいただいた箇所について、acceptしておきましたので確認お願いいたします！

@jp-knj
Copy link
Member

jp-knj commented Oct 8, 2025

LGTM

@Copilot Copilot AI review requested due to automatic review settings October 8, 2025 13:55
Copilot
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Japanese localization for the Astro courses page, translating content that helps Japanese users discover learning resources for Astro. The translation includes course information, educational partners, and community learning resources.

  • Translates the entire /astro-courses/ page content to Japanese
  • Maintains all functional components and links while localizing descriptive text
  • Provides Japanese users with access to Astro learning resources in their native language

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

yanthomasdev
yanthomasdev approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙌

@yanthomasdev yanthomasdev merged commit 9e681fa into withastro:main Oct 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jp-knj jp-knj jp-knj requested changes

Copilot code review Copilot Copilot left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kenzo-Wada @astrobot-houston @jp-knj @yanthomasdev